Spark is_valid_utf8 function implementation#21627
Merged
Jefffrey merged 8 commits intoapache:mainfrom Apr 19, 2026
Merged
Conversation
# Conflicts: # datafusion/spark/src/function/string/mod.rs
Jefffrey
reviewed
Apr 17, 2026
| fn spark_is_valid_utf8_inner(args: &[ArrayRef]) -> Result<ArrayRef> { | ||
| let [array] = take_function_args("is_valid_utf8", args)?; | ||
| match array.data_type() { | ||
| DataType::Utf8 => Ok(Arc::new( |
Contributor
There was a problem hiding this comment.
Utf8 types should always be valid, unless theres an edge case I'm missing? We'd just need to return a BinaryArray with all true values, and take the null buffer from input array
Contributor
Author
There was a problem hiding this comment.
Good point! Thanks, fixed.
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
Contributor
There was a problem hiding this comment.
Would be a good idea to have null test too, as well as array input test (currently these are all scalars)
| DataType::Binary => Ok(Arc::new( | ||
| as_binary_array(array)? | ||
| .iter() | ||
| .map(|x| x.map(|y| String::from_utf8(y.into()).is_ok())) |
Contributor
There was a problem hiding this comment.
Suggested change
| .map(|x| x.map(|y| String::from_utf8(y.into()).is_ok())) | |
| .map(|x| x.map(|y| str::from_utf8(y).is_ok())) |
Avoid need of allocation
Jefffrey
approved these changes
Apr 18, 2026
Contributor
|
Thanks @kazantsev-maksim |
Contributor
Author
|
Thanks for the review @Jefffrey |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Add new spark function: https://spark.apache.org/docs/latest/api/sql/index.html#is_valid_utf8
What changes are included in this PR?
Are these changes tested?
Yes, tests added as part of this PR.
Are there any user-facing changes?
No, these are new function.